diff options
| author | Eric Dumazet <edumazet@google.com> | 2016-11-16 06:31:52 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-11-16 23:30:43 -0500 |
| commit | e5f6f564fd191d365fcd775c06a732a488205588 (patch) | |
| tree | 28db9d98d66cf6f39f59230d93a58311d77d9d0b /drivers/net/ethernet/broadcom | |
| parent | e47112d9d6009bf6b7438cedc0270316d6b0370d (diff) | |
| download | linux-e5f6f564fd191d365fcd775c06a732a488205588.tar.bz2 | |
bnxt: add a missing rcu synchronization
Add a missing synchronize_net() call to avoid potential use after free,
since we explicitly call napi_hash_del() to factorize the RCU grace
period.
Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Michael Chan <michael.chan@broadcom.com>
Acked-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom')
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index c6909660e097..e18635b2a002 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -4934,6 +4934,10 @@ static void bnxt_del_napi(struct bnxt *bp) napi_hash_del(&bnapi->napi); netif_napi_del(&bnapi->napi); } + /* We called napi_hash_del() before netif_napi_del(), we need + * to respect an RCU grace period before freeing napi structures. + */ + synchronize_net(); } static void bnxt_init_napi(struct bnxt *bp) |