summaryrefslogtreecommitdiffstats
path: root/drivers/net/dsa
diff options
context:
space:
mode:
authorFlorian Fainelli <f.fainelli@gmail.com>2016-06-20 18:26:53 -0700
committerDavid S. Miller <davem@davemloft.net>2016-06-23 15:13:48 -0400
commit51dca8a1cfd917e1b53b118ddd3fbe5eb1b6a9a8 (patch)
tree2de933dd95feadfca20a285db293816e49587fb2 /drivers/net/dsa
parentd1bd330a229fc8a69f0e7532138dfd42b4542fd4 (diff)
downloadlinux-51dca8a1cfd917e1b53b118ddd3fbe5eb1b6a9a8.tar.bz2
net: dsa: b53: Fix statistics readings
Due to a typo we would always be using the MIB counter width of the first element of the counter array instead of the current element, and we would always be accessing the register statistics with a 64-bits read, while some could be 32-bits. This got unnoticed in testing with MDIO and SRAB which tolerate doing this, but testing with the SPI bus revealed bogus values being returned. Fix this by using the proper iterator here. Fixes: 967dd82ffc52 ("net: dsa: b53: Add support for Broadcom RoboSwitch") Reported-by: Jonas Gorski <jogo@openwrt.org> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa')
-rw-r--r--drivers/net/dsa/b53/b53_common.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c
index 5321083379c7..444de66667b9 100644
--- a/drivers/net/dsa/b53/b53_common.c
+++ b/drivers/net/dsa/b53/b53_common.c
@@ -679,7 +679,7 @@ static void b53_get_ethtool_stats(struct dsa_switch *ds, int port,
for (i = 0; i < mib_size; i++) {
s = &mibs[i];
- if (mibs->size == 8) {
+ if (s->size == 8) {
b53_read64(dev, B53_MIB_PAGE(port), s->offset, &val);
} else {
u32 val32;