diff options
author | Tiezhu Yang <yangtiezhu@loongson.cn> | 2020-05-22 19:03:21 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-05-23 16:28:25 -0700 |
commit | ef24d6c3d6965158dfe23ae961d87e9a343e18a2 (patch) | |
tree | 923489ccb4df091a557366098084e2541dc0a713 /drivers/net/can | |
parent | d04322a0da1e86aedaa322ce933cfb8c0191d1eb (diff) | |
download | linux-ef24d6c3d6965158dfe23ae961d87e9a343e18a2.tar.bz2 |
net: Fix return value about devm_platform_ioremap_resource()
When call function devm_platform_ioremap_resource(), we should use IS_ERR()
to check the return value and return PTR_ERR() if failed.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/can')
-rw-r--r-- | drivers/net/can/ifi_canfd/ifi_canfd.c | 5 | ||||
-rw-r--r-- | drivers/net/can/sun4i_can.c | 2 |
2 files changed, 5 insertions, 2 deletions
diff --git a/drivers/net/can/ifi_canfd/ifi_canfd.c b/drivers/net/can/ifi_canfd/ifi_canfd.c index 04d59bede5ea..74503cacf594 100644 --- a/drivers/net/can/ifi_canfd/ifi_canfd.c +++ b/drivers/net/can/ifi_canfd/ifi_canfd.c @@ -947,8 +947,11 @@ static int ifi_canfd_plat_probe(struct platform_device *pdev) u32 id, rev; addr = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(addr)) + return PTR_ERR(addr); + irq = platform_get_irq(pdev, 0); - if (IS_ERR(addr) || irq < 0) + if (irq < 0) return -EINVAL; id = readl(addr + IFI_CANFD_IP_ID); diff --git a/drivers/net/can/sun4i_can.c b/drivers/net/can/sun4i_can.c index e3ba8ab0cbf4..e2c6cf4b2228 100644 --- a/drivers/net/can/sun4i_can.c +++ b/drivers/net/can/sun4i_can.c @@ -792,7 +792,7 @@ static int sun4ican_probe(struct platform_device *pdev) addr = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(addr)) { - err = -EBUSY; + err = PTR_ERR(addr); goto exit; } |