summaryrefslogtreecommitdiffstats
path: root/drivers/mtd
diff options
context:
space:
mode:
authorCyril Bur <cyrilbur@gmail.com>2017-11-03 13:41:37 +1100
committerMichael Ellerman <mpe@ellerman.id.au>2017-11-06 20:20:26 +1100
commit44e2aa2b16a872fa8aa4901b3793132e6cfd293a (patch)
treef7311cd56ba0daf1aa5979568403076bbc3ceb17 /drivers/mtd
parent71e24d7731a2903b1ae2bba2b2971c654d9c2aa6 (diff)
downloadlinux-44e2aa2b16a872fa8aa4901b3793132e6cfd293a.tar.bz2
mtd: powernv_flash: Use WARN_ON_ONCE() rather than BUG_ON()
BUG_ON() should be reserved in situations where we can not longer guarantee the integrity of the system. In the case where powernv_flash_async_op() receives an impossible op, we can still guarantee the integrity of the system. Signed-off-by: Cyril Bur <cyrilbur@gmail.com> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'drivers/mtd')
-rw-r--r--drivers/mtd/devices/powernv_flash.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/powernv_flash.c
index f5396f26ddb4..f9ec38281ff2 100644
--- a/drivers/mtd/devices/powernv_flash.c
+++ b/drivers/mtd/devices/powernv_flash.c
@@ -78,7 +78,9 @@ static int powernv_flash_async_op(struct mtd_info *mtd, enum flash_op op,
rc = opal_flash_erase(info->id, offset, len, token);
break;
default:
- BUG_ON(1);
+ WARN_ON_ONCE(1);
+ opal_async_release_token(token);
+ return -EIO;
}
if (rc != OPAL_ASYNC_COMPLETION) {