diff options
| author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2017-06-13 22:45:36 +0900 |
|---|---|---|
| committer | Boris Brezillon <boris.brezillon@free-electrons.com> | 2017-06-20 09:14:25 +0200 |
| commit | 959e9f2ae9dac4821d7da354a37272650febebbe (patch) | |
| tree | 4922e3ceb5f0db0faebc28da7042c47fd26d6457 /drivers/mtd/nand/denali.h | |
| parent | b21ff825d6b7fa7122f9c4455f9a0f157b9fb225 (diff) | |
| download | linux-959e9f2ae9dac4821d7da354a37272650febebbe.tar.bz2 | |
mtd: nand: denali: remove unneeded find_valid_banks()
The function find_valid_banks() issues the Read ID (0x90) command,
then compares the first byte (Manufacturer ID) of each bank with
the one of bank0.
This is equivalent to what nand_scan_ident() does. The number of
chips is detected there, so this is unneeded.
What is worse for find_valid_banks() is that, if multiple chips are
connected to INTEL_CE4100 platform, it crashes the kernel by BUG().
This is what we should avoid. This function is just harmful and
unneeded.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Diffstat (limited to 'drivers/mtd/nand/denali.h')
| -rw-r--r-- | drivers/mtd/nand/denali.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/mtd/nand/denali.h b/drivers/mtd/nand/denali.h index 352d8328b94a..0e4a8965f6f1 100644 --- a/drivers/mtd/nand/denali.h +++ b/drivers/mtd/nand/denali.h @@ -326,7 +326,6 @@ struct denali_nand_info { int platform; struct nand_buf buf; struct device *dev; - int total_used_banks; int page; void __iomem *flash_reg; /* Register Interface */ void __iomem *flash_mem; /* Host Data/Command Interface */ |