summaryrefslogtreecommitdiffstats
path: root/drivers/misc
diff options
context:
space:
mode:
authorOded Gabbay <oded.gabbay@gmail.com>2019-02-26 11:23:34 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-02-26 11:35:03 +0100
commit4398e7057d66050b4121b97da048bfe3fdaf4c8d (patch)
tree87dfea73893e480b56102f03d42335c44a8b49ac /drivers/misc
parent8737d037209fe97a98863047cc2789b38c3d3681 (diff)
downloadlinux-4398e7057d66050b4121b97da048bfe3fdaf4c8d.tar.bz2
habanalabs: return error when failing to read/write i2c
The driver can't read/write from i2c if the device is in reset or disabled. Therefore, return -EBUSY in those cases instead of 0. This change also fixes a smatch warning about uninitialized variable. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc')
-rw-r--r--drivers/misc/habanalabs/debugfs.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/misc/habanalabs/debugfs.c b/drivers/misc/habanalabs/debugfs.c
index a6d9d809385e..f472b572faea 100644
--- a/drivers/misc/habanalabs/debugfs.c
+++ b/drivers/misc/habanalabs/debugfs.c
@@ -25,7 +25,7 @@ static int hl_debugfs_i2c_read(struct hl_device *hdev, u8 i2c_bus, u8 i2c_addr,
int rc;
if (hl_device_disabled_or_in_reset(hdev))
- return 0;
+ return -EBUSY;
memset(&pkt, 0, sizeof(pkt));
@@ -50,7 +50,7 @@ static int hl_debugfs_i2c_write(struct hl_device *hdev, u8 i2c_bus, u8 i2c_addr,
int rc;
if (hl_device_disabled_or_in_reset(hdev))
- return 0;
+ return -EBUSY;
memset(&pkt, 0, sizeof(pkt));