diff options
author | Amitoj Kaur Chawla <amitoj1606@gmail.com> | 2016-01-25 22:57:48 +0530 |
---|---|---|
committer | Thierry Reding <treding@nvidia.com> | 2016-06-14 11:39:38 +0200 |
commit | aafb197f75cec20331c84ade2da9bc94ae0b9aff (patch) | |
tree | 7a17482791ee491cca66adec3507d349c80f93c7 /drivers/memory/tegra | |
parent | 1a695a905c18548062509178b98bc91e67510864 (diff) | |
download | linux-aafb197f75cec20331c84ade2da9bc94ae0b9aff.tar.bz2 |
memory: tegra: tegra124-emc: Add missing of_node_put()
for_each_child_of_node() performs an of_node_get() on each iteration, so
to break out of the loop an of_node_put() is required.
Found using Coccinelle. The semantic patch used for this is as follows:
// <smpl>
@@
expression e;
local idexpression n;
@@
for_each_child_of_node(..., n) {
... when != of_node_put(n)
when != e = n
(
return n;
|
+ of_node_put(n);
? return ...;
)
...
}
// </smpl>
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Diffstat (limited to 'drivers/memory/tegra')
-rw-r--r-- | drivers/memory/tegra/tegra124-emc.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c index 3dac7be39654..02a63177c6e7 100644 --- a/drivers/memory/tegra/tegra124-emc.c +++ b/drivers/memory/tegra/tegra124-emc.c @@ -970,8 +970,10 @@ static int tegra_emc_load_timings_from_dt(struct tegra_emc *emc, timing = &emc->timings[i++]; err = load_one_timing_from_dt(emc, timing, child); - if (err) + if (err) { + of_node_put(child); return err; + } } sort(emc->timings, emc->num_timings, sizeof(*timing), cmp_timings, |