summaryrefslogtreecommitdiffstats
path: root/drivers/media/dvb-frontends
diff options
context:
space:
mode:
authorAditya Pakki <pakki001@umn.edu>2018-12-27 13:58:01 -0500
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>2019-01-16 11:45:33 -0500
commit467a37fba93f2b4fe3ab597ff6a517b22b566882 (patch)
tree849ce0d03886a9c479df8201cc84a98a23de372d /drivers/media/dvb-frontends
parent0f787c12ee7b2b41a74594ed158a0112736f4e4e (diff)
downloadlinux-467a37fba93f2b4fe3ab597ff6a517b22b566882.tar.bz2
media: dvb: Add check on sp8870_readreg
In sp8870_set_frontend_parameters, the function sp8870_readreg may return an error when i2c_transfer fails. The fix checks for this error and returns upstream consistent with other invocations. Signed-off-by: Aditya Pakki <pakki001@umn.edu> Signed-off-by: Sean Young <sean@mess.org> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media/dvb-frontends')
-rw-r--r--drivers/media/dvb-frontends/sp8870.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/media/dvb-frontends/sp8870.c b/drivers/media/dvb-frontends/sp8870.c
index 8d31cf3f4f07..270a3c559e08 100644
--- a/drivers/media/dvb-frontends/sp8870.c
+++ b/drivers/media/dvb-frontends/sp8870.c
@@ -293,7 +293,9 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe)
sp8870_writereg(state, 0xc05, reg0xc05);
// read status reg in order to clear pending irqs
- sp8870_readreg(state, 0x200);
+ err = sp8870_readreg(state, 0x200);
+ if (err)
+ return err;
// system controller start
sp8870_microcontroller_start(state);