diff options
| author | Takeshi Yoshimura <yos@sslab.ics.keio.ac.jp> | 2015-05-27 11:28:14 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2015-06-09 19:40:33 -0300 |
| commit | 25e057fdde3b33c0d18605ed27b59336a3441925 (patch) | |
| tree | 4ce35fd6ea668fa65b52ddbb9d1f0e75958e501d /drivers/media/common | |
| parent | ee8defeceafa05401573f3d2f1e3feca33e5a83c (diff) | |
| download | linux-25e057fdde3b33c0d18605ed27b59336a3441925.tar.bz2 | |
[media] ddbridge: Do not free_irq() if request_irq() failed
My static checker detected that free_irq() is called even after
request_irq() failed in ddb_probe(). In this case, the kernel may try to
free dev->pdev->irq although the IRQ is not assigned. This event rarely
occurs, but always introduces a warning if it happens.
"goto fail1" always results in disabling enabled MSI and releasing a
requested IRQ. It seems like the former handling is necessary. So I added
a conditional branch before the free_irq() (stat == 0 means request_irq()
succeeds).
Signed-off-by: Takeshi Yoshimura <yos@sslab.ics.keio.ac.jp>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/common')
0 files changed, 0 insertions, 0 deletions