diff options
| author | Xiao Ni <xni@redhat.com> | 2019-03-08 23:52:05 +0800 |
|---|---|---|
| committer | Song Liu <songliubraving@fb.com> | 2019-03-12 10:15:18 -0700 |
| commit | b761dcf1217760a42f7897c31dcb649f59b2333e (patch) | |
| tree | 0f1d15ec6bd8f579def328849b5e6c3c20ab4aa4 /drivers/md | |
| parent | a596d08677320925b69e70c0fdc4c0f59384a65e (diff) | |
| download | linux-b761dcf1217760a42f7897c31dcb649f59b2333e.tar.bz2 | |
It's wrong to add len to sector_nr in raid10 reshape twice
In reshape_request it already adds len to sector_nr already. It's wrong to add len to
sector_nr again after adding pages to bio. If there is bad block it can't copy one chunk
at a time, it needs to goto read_more. Now the sector_nr is wrong. It can cause data
corruption.
Cc: stable@vger.kernel.org # v3.16+
Signed-off-by: Xiao Ni <xni@redhat.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/raid10.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index abb5d382f64d..ecef42bfe19d 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -4670,7 +4670,6 @@ read_more: atomic_inc(&r10_bio->remaining); read_bio->bi_next = NULL; generic_make_request(read_bio); - sector_nr += nr_sectors; sectors_done += nr_sectors; if (sector_nr <= last) goto read_more; |