diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-01-07 11:45:38 -0600 |
|---|---|---|
| committer | Song Liu <songliubraving@fb.com> | 2019-02-04 10:37:11 -0800 |
| commit | f1e5b6239bdd46aa3f4e631611800ea7d10826c4 (patch) | |
| tree | 8564b4916e81019f3e82981d6dd35151d44da16e /drivers/md | |
| parent | bb94aea1444b9859faa8d72aff3713fcd11c6696 (diff) | |
| download | linux-f1e5b6239bdd46aa3f4e631611800ea7d10826c4.tar.bz2 | |
md-linear: use struct_size() in kzalloc()
One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:
struct foo {
int stuff;
void *entry[];
};
instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:
instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/md-linear.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c index d45c697c0ebe..5998d78aa189 100644 --- a/drivers/md/md-linear.c +++ b/drivers/md/md-linear.c @@ -96,8 +96,7 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks) int i, cnt; bool discard_supported = false; - conf = kzalloc (sizeof (*conf) + raid_disks*sizeof(struct dev_info), - GFP_KERNEL); + conf = kzalloc(struct_size(conf, disks, raid_disks), GFP_KERNEL); if (!conf) return NULL; |