diff options
| author | Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-07-23 16:09:10 +0530 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2019-07-26 14:27:22 +0100 |
| commit | 321275f0d8f5939f2a98749fe03ee97ac97e73d0 (patch) | |
| tree | 06f3adc62b87f1b7e29fcfe2fd1a5fb56a6c4d6a /drivers/irqchip | |
| parent | 34f8eb92ca053cbba2887bb7e4dbf2b2cd6eb733 (diff) | |
| download | linux-321275f0d8f5939f2a98749fe03ee97ac97e73d0.tar.bz2 | |
irqchip/irq-mbigen: Add of_node_put() before return
Each iteration of for_each_child_of_node puts the previous node, but
in the case of a return from the middle of the loop, there is no put,
thus causing a memory leak. Add an of_node_put before the return in
three places.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Diffstat (limited to 'drivers/irqchip')
| -rw-r--r-- | drivers/irqchip/irq-mbigen.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c index c0f65ea0ae0f..64f3574cc009 100644 --- a/drivers/irqchip/irq-mbigen.c +++ b/drivers/irqchip/irq-mbigen.c @@ -252,12 +252,15 @@ static int mbigen_of_create_domain(struct platform_device *pdev, parent = platform_bus_type.dev_root; child = of_platform_device_create(np, NULL, parent); - if (!child) + if (!child) { + of_node_put(np); return -ENOMEM; + } if (of_property_read_u32(child->dev.of_node, "num-pins", &num_pins) < 0) { dev_err(&pdev->dev, "No num-pins property\n"); + of_node_put(np); return -EINVAL; } @@ -265,8 +268,10 @@ static int mbigen_of_create_domain(struct platform_device *pdev, mbigen_write_msg, &mbigen_domain_ops, mgn_chip); - if (!domain) + if (!domain) { + of_node_put(np); return -ENOMEM; + } } return 0; |