diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2020-05-19 09:18:57 +0000 |
|---|---|---|
| committer | Joerg Roedel <jroedel@suse.de> | 2020-05-19 14:06:15 +0200 |
| commit | ae7d292324b4be60b6d39d2e06bf2a63752f3fcd (patch) | |
| tree | bc22ccd970c1dd003603c77cf59b049a3549d609 /drivers/iommu | |
| parent | 38b91f810b6873bcdfd6ef441e9a3794a9c69101 (diff) | |
| download | linux-ae7d292324b4be60b6d39d2e06bf2a63752f3fcd.tar.bz2 | |
iommu/sun50i: Fix return value check in sun50i_iommu_probe()
In case of error, the function devm_platform_ioremap_resource() returns
ERR_PTR() not NULL. The NULL test in the return value check must be
replaced with IS_ERR().
Fixes: 4100b8c229b3 ("iommu: Add Allwinner H6 IOMMU driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Link: https://lore.kernel.org/r/20200519091857.134170-1-weiyongjun1@huawei.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu')
| -rw-r--r-- | drivers/iommu/sun50i-iommu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/sun50i-iommu.c b/drivers/iommu/sun50i-iommu.c index 9c763d4a8e2a..1fa09ddcebd4 100644 --- a/drivers/iommu/sun50i-iommu.c +++ b/drivers/iommu/sun50i-iommu.c @@ -941,7 +941,7 @@ static int sun50i_iommu_probe(struct platform_device *pdev) } iommu->base = devm_platform_ioremap_resource(pdev, 0); - if (!iommu->base) { + if (IS_ERR(iommu->base)) { ret = PTR_ERR(iommu->base); goto err_free_group; } |