diff options
author | Cong Wang <xiyou.wangcong@gmail.com> | 2018-06-01 11:31:44 -0700 |
---|---|---|
committer | Jason Gunthorpe <jgg@mellanox.com> | 2018-06-04 09:37:03 -0600 |
commit | cb2595c1393b4a5211534e6f0a0fbad369e21ad8 (patch) | |
tree | 33be75d40a02b98c22b30fa6aa129d8850858f22 /drivers/infiniband/hw/hfi1/file_ops.c | |
parent | e4b1672ac0a54c7740cbc4ff39dfdc56182236cb (diff) | |
download | linux-cb2595c1393b4a5211534e6f0a0fbad369e21ad8.tar.bz2 |
infiniband: fix a possible use-after-free bug
ucma_process_join() will free the new allocated "mc" struct,
if there is any error after that, especially the copy_to_user().
But in parallel, ucma_leave_multicast() could find this "mc"
through idr_find() before ucma_process_join() frees it, since it
is already published.
So "mc" could be used in ucma_leave_multicast() after it is been
allocated and freed in ucma_process_join(), since we don't refcnt
it.
Fix this by separating "publish" from ID allocation, so that we
can get an ID first and publish it later after copy_to_user().
Fixes: c8f6a362bf3e ("RDMA/cma: Add multicast communication support")
Reported-by: Noam Rathaus <noamr@beyondsecurity.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to 'drivers/infiniband/hw/hfi1/file_ops.c')
0 files changed, 0 insertions, 0 deletions