diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2018-12-26 11:28:24 +0000 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2019-01-06 19:49:14 -0800 |
| commit | 07bd14ccc3049f9c0147a91a4227a571f981601a (patch) | |
| tree | e607e74e5cb860a6e1c6f85a9403c6bd15934ee0 /drivers/hwmon | |
| parent | 9de15c95a63f527c8f7a968cd95e6ec71fc6891d (diff) | |
| download | linux-07bd14ccc3049f9c0147a91a4227a571f981601a.tar.bz2 | |
hwmon: (lm80) Fix missing unlock on error in set_fan_div()
Add the missing unlock before return from function set_fan_div()
in the error handling case.
Fixes: c9c63915519b ("hwmon: (lm80) fix a missing check of the status of SMBus read")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/lm80.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/hwmon/lm80.c b/drivers/hwmon/lm80.c index 0e30fa00204c..f9b8e3e23a8e 100644 --- a/drivers/hwmon/lm80.c +++ b/drivers/hwmon/lm80.c @@ -393,8 +393,10 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *attr, } rv = lm80_read_value(client, LM80_REG_FANDIV); - if (rv < 0) + if (rv < 0) { + mutex_unlock(&data->update_lock); return rv; + } reg = (rv & ~(3 << (2 * (nr + 1)))) | (data->fan_div[nr] << (2 * (nr + 1))); lm80_write_value(client, LM80_REG_FANDIV, reg); |