summaryrefslogtreecommitdiffstats
path: root/drivers/hwmon/pmbus
diff options
context:
space:
mode:
authorVadim Pasternak <vadimp@mellanox.com>2019-02-18 19:54:40 +0000
committerGuenter Roeck <linux@roeck-us.net>2019-02-18 14:22:52 -0800
commitff066653aeed8ee2d4dadb1e35774dd91ecbb19f (patch)
tree34c5669eb9b7ef2a4efaebd2bff9898a36be335b /drivers/hwmon/pmbus
parenta3b22b9f11d9fbc48b0291ea92259a5a810e9438 (diff)
downloadlinux-ff066653aeed8ee2d4dadb1e35774dd91ecbb19f.tar.bz2
hwmon: (pmbus/tps53679) Fix driver info initialization in probe routine
Fix tps53679_probe() by using dynamically allocated "pmbus_driver_info" structure instead of static. Usage of static structures causes overwritten of the field "vrm_version", in case the system is equipped with several tps53679 devices with the different "vrm_version". In such case the last probed device overwrites this field for all others. Fixes: 610526527a13 ("hwmon: (pmbus) Add support for Texas Instruments tps53679 device") Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/pmbus')
-rw-r--r--drivers/hwmon/pmbus/tps53679.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/drivers/hwmon/pmbus/tps53679.c b/drivers/hwmon/pmbus/tps53679.c
index 85b515cd9df0..2bc352c5357f 100644
--- a/drivers/hwmon/pmbus/tps53679.c
+++ b/drivers/hwmon/pmbus/tps53679.c
@@ -80,7 +80,14 @@ static struct pmbus_driver_info tps53679_info = {
static int tps53679_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
- return pmbus_do_probe(client, id, &tps53679_info);
+ struct pmbus_driver_info *info;
+
+ info = devm_kmemdup(&client->dev, &tps53679_info, sizeof(*info),
+ GFP_KERNEL);
+ if (!info)
+ return -ENOMEM;
+
+ return pmbus_do_probe(client, id, info);
}
static const struct i2c_device_id tps53679_id[] = {