diff options
| author | Guenter Roeck <guenter.roeck@ericsson.com> | 2011-08-26 08:12:38 -0700 |
|---|---|---|
| committer | Guenter Roeck <guenter.roeck@ericsson.com> | 2011-10-24 11:09:33 -0700 |
| commit | 866cf12a0eab65f94e40608bdd21ca8dea4d0ac2 (patch) | |
| tree | 4f419b461893f90d6e9a54f0852c3bd1a6254666 /drivers/hwmon/pmbus/adm1275.c | |
| parent | 20fcfe172190704918969695a16cf621e2f4ce25 (diff) | |
| download | linux-866cf12a0eab65f94e40608bdd21ca8dea4d0ac2.tar.bz2 | |
hwmon: (pmbus) Don't return errors from driver remove functions
Driver remove functions have an error return value, but rarely return an error
in practice. If a driver does return an error from its remove function, the
driver won't be unloaded and is expected to stay alive.
pmbus_do_remove() is defined as returning an int, but always returns 0 (no
error). Calling code passes that return value on to high level driver
remove functions, but does not evaluate it and removes driver data even if
pmbus_do_remove() returned an error (which it in practice never does). Even if
this code could never cause a real problem, it is nevertheless conceptually
wrong.
To reduce confusion and simplify the code, change pmbus_do_remove() to be a void
function, and have PMBus client drivers always return zero in their driver
remove functions.
Reported-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Acked-by: Jean Delvare <khali@linux-fr.org>
Diffstat (limited to 'drivers/hwmon/pmbus/adm1275.c')
| -rw-r--r-- | drivers/hwmon/pmbus/adm1275.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c index c936e2782309..424d0d711ccb 100644 --- a/drivers/hwmon/pmbus/adm1275.c +++ b/drivers/hwmon/pmbus/adm1275.c @@ -152,11 +152,10 @@ err_mem: static int adm1275_remove(struct i2c_client *client) { const struct pmbus_driver_info *info = pmbus_get_driver_info(client); - int ret; - ret = pmbus_do_remove(client); + pmbus_do_remove(client); kfree(info); - return ret; + return 0; } static const struct i2c_device_id adm1275_id[] = { |