summaryrefslogtreecommitdiffstats
path: root/drivers/hwmon/nct7802.c
diff options
context:
space:
mode:
authorWan Jiabing <wanjiabing@vivo.com>2021-10-28 22:49:18 -0400
committerGuenter Roeck <linux@roeck-us.net>2021-10-28 21:27:38 -0700
commit10f0d2ab9aa672707559d46601fd35544759ff70 (patch)
treed5aad4fbb2069c2636c4aa8491a24b81fdc2221b /drivers/hwmon/nct7802.c
parent38d9f06c57403383d574727d9978ad049b011197 (diff)
downloadlinux-10f0d2ab9aa672707559d46601fd35544759ff70.tar.bz2
hwmon: (nct7802) Add of_node_put() before return
Fix following coccicheck warning: ./drivers/hwmon/nct7802.c:1152:2-24: WARNING: Function for_each_child_of_node should have of_node_put() before return. Early exits from for_each_child_of_node should decrement the node reference counter. Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> Link: https://lore.kernel.org/r/20211029024918.5161-1-wanjiabing@vivo.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/nct7802.c')
-rw-r--r--drivers/hwmon/nct7802.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c
index d56f78327619..d1eeef02b6dc 100644
--- a/drivers/hwmon/nct7802.c
+++ b/drivers/hwmon/nct7802.c
@@ -1152,8 +1152,10 @@ static int nct7802_configure_channels(struct device *dev,
for_each_child_of_node(dev->of_node, node) {
err = nct7802_get_channel_config(dev, node, &mode_mask,
&mode_val);
- if (err)
+ if (err) {
+ of_node_put(node);
return err;
+ }
}
}