diff options
| author | Valtteri Heikkilä <rnd@nic.fi> | 2017-02-14 23:14:32 +0000 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2017-03-06 14:02:37 +0100 |
| commit | 3f3752705dbd50b66b66ad7b4d54fe33d2f746ed (patch) | |
| tree | 9e7627aebcaa91d143db8d3cd11b3a44fa913946 /drivers/hid/hid-input.c | |
| parent | 81bbef23db51c0b450d90607fbbc2ad80ee0d43f (diff) | |
| download | linux-3f3752705dbd50b66b66ad7b4d54fe33d2f746ed.tar.bz2 | |
HID: reject input outside logical range only if null state is set
This patch fixes an issue in drivers/hid/hid-input.c where USB HID
control null state flag is not checked upon rejecting inputs outside
logical minimum-maximum range. The check should be made according to USB
HID specification 1.11, section 6.2.2.5, p.31. The fix will resolve
issues with some game controllers, such as:
https://bugzilla.kernel.org/show_bug.cgi?id=68621
[tk@the-tk.com: shortened and fixed spelling in commit message]
Signed-off-by: Valtteri Heikkilä <rnd@nic.fi>
Signed-off-by: Tomasz Kramkowski <tk@the-tk.com>
Acked-By: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-input.c')
| -rw-r--r-- | drivers/hid/hid-input.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index d05f903c7614..cf8256aac2bd 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -1157,6 +1157,7 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct * don't specify logical min and max. */ if ((field->flags & HID_MAIN_ITEM_VARIABLE) && + (field->flags & HID_MAIN_ITEM_NULL_STATE) && (field->logical_minimum < field->logical_maximum) && (value < field->logical_minimum || value > field->logical_maximum)) { |