diff options
| author | Ezequiel Garcia <ezequiel@collabora.com> | 2019-01-02 14:55:06 -0300 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2019-01-08 11:45:19 +0100 |
| commit | 29cd2e2dac799e5f243d6d3c68bf3834b65b204e (patch) | |
| tree | 0d3bb8c3cd8ac09d3bbc2a30627e55008ac1237f /drivers/gpu/drm/virtio | |
| parent | be5cadc7e7b4cee83cdd19e58a9dc0eca9e23b69 (diff) | |
| download | linux-29cd2e2dac799e5f243d6d3c68bf3834b65b204e.tar.bz2 | |
drm/virtio: Remove incorrect kfree()
The virtio_gpu_output is a member of struct virtio_gpu_device
and is not a dynamically-allocated chunk, so it's wrong to kfree() it.
Removing it fixes a memory corruption BUG() that can be triggered
when the virtio-gpu driver is removed.
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20190102175507.4653-1-ezequiel@collabora.com
Diffstat (limited to 'drivers/gpu/drm/virtio')
| -rw-r--r-- | drivers/gpu/drm/virtio/virtgpu_display.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index e1c223e18d86..d539bc28dc97 100644 --- a/drivers/gpu/drm/virtio/virtgpu_display.c +++ b/drivers/gpu/drm/virtio/virtgpu_display.c @@ -243,12 +243,8 @@ static enum drm_connector_status virtio_gpu_conn_detect( static void virtio_gpu_conn_destroy(struct drm_connector *connector) { - struct virtio_gpu_output *virtio_gpu_output = - drm_connector_to_virtio_gpu_output(connector); - drm_connector_unregister(connector); drm_connector_cleanup(connector); - kfree(virtio_gpu_output); } static const struct drm_connector_funcs virtio_gpu_connector_funcs = { |