summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/vgem
diff options
context:
space:
mode:
authorWei Yongjun <weiyongjun1@huawei.com>2017-05-21 01:19:39 +0000
committerDaniel Vetter <daniel.vetter@ffwll.ch>2017-05-22 09:47:34 +0200
commite8fa49b5d974846d367b103edc026c4d2b90ebfd (patch)
tree0cfef27fd95b90636eec6d199c8746dd779fefe1 /drivers/gpu/drm/vgem
parenta18e6621d200193392369b84280e259077e75381 (diff)
downloadlinux-e8fa49b5d974846d367b103edc026c4d2b90ebfd.tar.bz2
drm/vgem: Fix return value check in vgem_init()
In case of error, the function platform_device_register_simple() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: af33a9190d02 ("drm/vgem: Enable dmabuf import interfaces") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> [danvet: Fix fixes: tag per Chris' review.] Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: http://patchwork.freedesktop.org/patch/msgid/20170521011939.8111-1-weiyj.lk@gmail.com
Diffstat (limited to 'drivers/gpu/drm/vgem')
-rw-r--r--drivers/gpu/drm/vgem/vgem_drv.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index 54ec94c5e9ac..18f401b442c2 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -438,8 +438,8 @@ static int __init vgem_init(void)
vgem_device->platform =
platform_device_register_simple("vgem", -1, NULL, 0);
- if (!vgem_device->platform) {
- ret = -ENODEV;
+ if (IS_ERR(vgem_device->platform)) {
+ ret = PTR_ERR(vgem_device->platform);
goto out_fini;
}