diff options
author | Chris Wilson <chris@chris-wilson.co.uk> | 2016-07-12 15:59:50 +0100 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2016-07-14 10:12:50 +0200 |
commit | 01d3434a565ada5ca084c68ec1e087ada5a7b157 (patch) | |
tree | de49d3013d23ea9e3b235b0e66d05c228b6b5147 /drivers/gpu/drm/qxl | |
parent | 31954660a7a613cd01e6ab1e90e7fea6ca6ffc74 (diff) | |
download | linux-01d3434a565ada5ca084c68ec1e087ada5a7b157.tar.bz2 |
drm: Don't overwrite user ioctl arg unless requested
Currently, we completely ignore the user when it comes to the in/out
direction of the ioctl argument, as we simply cannot trust userspace.
(For example, they might request a copy of the modified ioctl argument
when the driver is not expecting such and so leak kernel stack.)
However, blindly copying over the target address may also lead to a
spurious EFAULT, and a failure after the ioctl was completed
successfully. This is important in order to avoid an ABI break when
extending an ioctl from IOR to IORW. Similar to how we only copy the
intersection of the kernel arg size and the user arg size, we only want
to copy back the kernel arg data iff both the kernel and userspace
request the copy.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1468335590-21023-1-git-send-email-chris@chris-wilson.co.uk
Diffstat (limited to 'drivers/gpu/drm/qxl')
0 files changed, 0 insertions, 0 deletions