diff options
| author | Vladimir Zapolskiy <vz@mleia.com> | 2018-12-08 16:38:41 +0200 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2018-12-10 09:10:46 +0100 |
| commit | 67566ae474e628c0077163d1e20d09d3e33b0ae3 (patch) | |
| tree | 68236d933b38ccf3e12c2b9ddf8fd0ed3dda711d /drivers/gpio | |
| parent | b00b7980af8a126976105ec68664a72bb72c6db2 (diff) | |
| download | linux-67566ae474e628c0077163d1e20d09d3e33b0ae3.tar.bz2 | |
gpio: lpc18xx: fix GPIO controller driver build as a module
The problem is reported for allmodconfig build setup:
ERROR: "irq_chip_retrigger_hierarchy" [drivers/gpio/gpio-lpc18xx.ko] undefined!
make[2]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
make[1]: *** [Makefile:1271: modules] Error 2
My testing in runtime shows that it is sufficient to remove .irq_retrigger
callback, which is assigned to unexported irq_chip_retrigger_hierarchy()
function, I did't observe any regressions, and thus apparently it is a
better fix rather than exporting the function defined in kernel/irq/chip.c
(see commit 52b2a05fa7c8 ("genirq: Export IRQ functions for module use"))
or sticking the GPIO controller driver build to built-in option only.
Reported-by: kbuild test robot <lkp@intel.com>
Fixes: 5ddabfe8d3de ("gpio: lpc18xx: add GPIO pin interrupt controller support")
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio')
| -rw-r--r-- | drivers/gpio/gpio-lpc18xx.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-lpc18xx.c b/drivers/gpio/gpio-lpc18xx.c index 040fb59d06f7..d441dbaed7a3 100644 --- a/drivers/gpio/gpio-lpc18xx.c +++ b/drivers/gpio/gpio-lpc18xx.c @@ -11,7 +11,6 @@ #include <linux/gpio/driver.h> #include <linux/io.h> #include <linux/irqdomain.h> -#include <linux/irqchip.h> #include <linux/module.h> #include <linux/of.h> #include <linux/of_address.h> @@ -158,7 +157,6 @@ static struct irq_chip lpc18xx_gpio_pin_ic = { .irq_unmask = lpc18xx_gpio_pin_ic_unmask, .irq_eoi = lpc18xx_gpio_pin_ic_eoi, .irq_set_type = lpc18xx_gpio_pin_ic_set_type, - .irq_retrigger = irq_chip_retrigger_hierarchy, .flags = IRQCHIP_SET_TYPE_MASKED, }; |