summaryrefslogtreecommitdiffstats
path: root/drivers/gpio/gpio-winbond.c
diff options
context:
space:
mode:
authorAhmad Fatoum <a.fatoum@pengutronix.de>2020-07-31 14:38:36 +0200
committerLinus Walleij <linus.walleij@linaro.org>2020-08-04 01:22:02 +0200
commit5f402bb17533113c21d61c2d4bc4ef4a6fa1c9a5 (patch)
treeab2c1f0d7491c03dd164bc29ad370f2bfb52da6c /drivers/gpio/gpio-winbond.c
parentbb58a47a120b888de6b996472b282fea02210f38 (diff)
downloadlinux-5f402bb17533113c21d61c2d4bc4ef4a6fa1c9a5.tar.bz2
gpio: don't use same lockdep class for all devm_gpiochip_add_data users
Commit 959bc7b22bd2 ("gpio: Automatically add lockdep keys") documents in its commits message its intention to "create a unique class key for each driver". It does so by having gpiochip_add_data add in-place the definition of two static lockdep classes for LOCKDEP use. That way, every caller of the macro adds their gpiochip with unique lockdep classes. There are many indirect callers of gpiochip_add_data, however, via use of devm_gpiochip_add_data. devm_gpiochip_add_data has external linkage and all its users will share the same lockdep classes, which probably is not intended. Fix this by replicating the gpio_chip_add_data statics-in-macro for the devm_ version as well. Fixes: 959bc7b22bd2 ("gpio: Automatically add lockdep keys") Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Link: https://lore.kernel.org/r/20200731123835.8003-1-a.fatoum@pengutronix.de Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-winbond.c')
0 files changed, 0 insertions, 0 deletions