diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2012-12-04 09:02:45 -0800 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-12-04 09:02:45 -0800 |
commit | ca50496eb487b639de1f502e77a48dde84152fb9 (patch) | |
tree | 73a2a57cb6dc9717daff0e8d7880928747e05b2d /drivers/gpio/gpio-tps65910.c | |
parent | 609e3ff3ff797c0ddba1c61c8eb83923586ed079 (diff) | |
parent | fc4b514f2727f74a4587c31db87e0e93465518c3 (diff) | |
download | linux-ca50496eb487b639de1f502e77a48dde84152fb9.tar.bz2 |
Merge branch 'for-3.7-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq
Pull workqueue fixes from Tejun Heo:
"So, safe fixes my ass.
Commit 8852aac25e79 ("workqueue: mod_delayed_work_on() shouldn't queue
timer on 0 delay") had the side-effect of performing delayed_work
sanity checks even when @delay is 0, which should be fine for any sane
use cases.
Unfortunately, megaraid was being overly ingenious. It seemingly
wanted to use cancel_delayed_work_sync() before cancel_work_sync() was
introduced, but didn't want to waste the space for full delayed_work
as it was only going to use 0 @delay. So, it only allocated space for
struct work_struct and then cast it to struct delayed_work and passed
it into delayed_work functions - truly awesome engineering tradeoff to
save some bytes.
Xiaotian fixed it by making megraid allocate full delayed_work for
now. It should be converted to use work_struct and cancel_work_sync()
but I think we better do that after 3.7.
I added another commit to change BUG_ON()s in __queue_delayed_work()
to WARN_ON_ONCE()s so that the kernel doesn't crash even if there are
more such abuses."
* 'for-3.7-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq:
workqueue: convert BUG_ON()s in __queue_delayed_work() to WARN_ON_ONCE()s
megaraid: fix BUG_ON() from incorrect use of delayed work
Diffstat (limited to 'drivers/gpio/gpio-tps65910.c')
0 files changed, 0 insertions, 0 deletions