summaryrefslogtreecommitdiffstats
path: root/drivers/firmware/dmi-id.c
diff options
context:
space:
mode:
authorSteven Rostedt <srostedt@redhat.com>2011-10-14 10:44:25 -0400
committerSteven Rostedt <rostedt@goodmis.org>2011-10-14 10:44:25 -0400
commit436fc280261dcfce5af38f08b89287750dc91cd2 (patch)
tree5a57ba115f7f9d19c0185673fa1bfba9dfc292da /drivers/firmware/dmi-id.c
parent9b5f8b31af57a8ce9e9f77864d9143b5e3304815 (diff)
downloadlinux-436fc280261dcfce5af38f08b89287750dc91cd2.tar.bz2
tracing: Fix returning of duplicate data after EOF in trace_pipe_raw
The trace_pipe_raw handler holds a cached page from the time the file is opened to the time it is closed. The cached page is used to handle the case of the user space buffer being smaller than what was read from the ring buffer. The left over buffer is held in the cache so that the next read will continue where the data left off. After EOF is returned (no more data in the buffer), the index of the cached page is set to zero. If a user app reads the page again after EOF, the check in the buffer will see that the cached page is less than page size and will return the cached page again. This will cause reading the trace_pipe_raw again after EOF to return duplicate data, making the output look like the time went backwards but instead data is just repeated. The fix is to not reset the index right after all data is read from the cache, but to reset it after all data is read and more data exists in the ring buffer. Cc: stable <stable@kernel.org> Reported-by: Jeremy Eder <jeder@redhat.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'drivers/firmware/dmi-id.c')
0 files changed, 0 insertions, 0 deletions