diff options
author | Liguang Zhang <zhangliguang@linux.alibaba.com> | 2020-02-21 16:35:09 +0000 |
---|---|---|
committer | Catalin Marinas <catalin.marinas@arm.com> | 2020-02-27 17:14:18 +0000 |
commit | f7d5ef0c654e827ba09e6eaadabc5a121c8a1cf4 (patch) | |
tree | 2a433ccf1f30bba1514e36b7466b50cc90cb64cc /drivers/firmware/arm_sdei.c | |
parent | 54f529a6806c9710947a4f2cdc15d6ea54121ccd (diff) | |
download | linux-f7d5ef0c654e827ba09e6eaadabc5a121c8a1cf4.tar.bz2 |
firmware: arm_sdei: clean up sdei_event_create()
Function sdei_event_find() is always called in sdei_event_create(), but
it is already called in sdei_event_register(). This code is trying to
avoid a double-create of the same event, which can't happen as we still
hold the sdei_events_lock. We can remove this needless sdei_event_find()
call.
Signed-off-by: Liguang Zhang <zhangliguang@linux.alibaba.com>
[expanded commit message]
Signed-off-by: James Morse <james.morse@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Diffstat (limited to 'drivers/firmware/arm_sdei.c')
-rw-r--r-- | drivers/firmware/arm_sdei.c | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c index 45536408a8c1..334c8be0c11f 100644 --- a/drivers/firmware/arm_sdei.c +++ b/drivers/firmware/arm_sdei.c @@ -267,15 +267,9 @@ static struct sdei_event *sdei_event_create(u32 event_num, event->private_registered = regs; } - if (sdei_event_find(event_num)) { - kfree(event->registered); - kfree(event); - event = ERR_PTR(-EBUSY); - } else { - spin_lock(&sdei_list_lock); - list_add(&event->list, &sdei_list); - spin_unlock(&sdei_list_lock); - } + spin_lock(&sdei_list_lock); + list_add(&event->list, &sdei_list); + spin_unlock(&sdei_list_lock); return event; } |