diff options
author | Mike Snitzer <snitzer@redhat.com> | 2017-11-14 15:40:52 -0500 |
---|---|---|
committer | Mike Snitzer <snitzer@redhat.com> | 2017-11-16 16:33:53 -0500 |
commit | 8a74d29d541cd86569139c6f3f44b2d210458071 (patch) | |
tree | 9d63231d6ca7c8964cbe94f9160e8595c7800451 /drivers/firewire | |
parent | 9dc112e2daf87b40607fd8d357e2d7de32290d45 (diff) | |
download | linux-8a74d29d541cd86569139c6f3f44b2d210458071.tar.bz2 |
dm: discard support requires all targets in a table support discards
A DM device with a mix of discard capabilities (due to some underlying
devices not having discard support) _should_ just return -EOPNOTSUPP for
the region of the device that doesn't support discards (even if only by
way of the underlying driver formally not supporting discards). BUT,
that does ask the underlying driver to handle something that it never
advertised support for. In doing so we're exposing users to the
potential for a underlying disk driver hanging if/when a discard is
issued a the device that is incapable and never claimed to support
discards.
Fix this by requiring that each DM target in a DM table provide discard
support as a prereq for a DM device to advertise support for discards.
This may cause some configurations that were happily supporting discards
(even in the face of a mix of discard support) to stop supporting
discards -- but the risk of users hitting driver hangs, and forced
reboots, outweighs supporting those fringe mixed discard
configurations.
Cc: stable@vger.kernel.org
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/firewire')
0 files changed, 0 insertions, 0 deletions