summaryrefslogtreecommitdiffstats
path: root/drivers/extcon/extcon.c
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2015-08-24 00:35:36 +0200
committerChanwoo Choi <cw00.choi@samsung.com>2015-09-21 15:07:19 +0900
commitf4513b065f7dbd37224226ef6e44b09eff742776 (patch)
tree29e311e448ab030241f808fc4603fa32a41e84de /drivers/extcon/extcon.c
parent1f93e4a96c9109378204c147b3eec0d0e8100fde (diff)
downloadlinux-f4513b065f7dbd37224226ef6e44b09eff742776.tar.bz2
extcon: Fix attached value returned by is_extcon_changed
is_extcon_changed should only check the idx-th bit of new, not the entirety of new when setting attached. This fixes extcon sending notifications that a cable was inserted when it gets removed while another cable is still connected. Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Diffstat (limited to 'drivers/extcon/extcon.c')
-rw-r--r--drivers/extcon/extcon.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index a07addde297b..8dd0af1d50bc 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -159,7 +159,7 @@ static int find_cable_index_by_name(struct extcon_dev *edev, const char *name)
static bool is_extcon_changed(u32 prev, u32 new, int idx, bool *attached)
{
if (((prev >> idx) & 0x1) != ((new >> idx) & 0x1)) {
- *attached = new ? true : false;
+ *attached = ((new >> idx) & 0x1) ? true : false;
return true;
}