diff options
| author | Nicolas Ferre <nicolas.ferre@microchip.com> | 2019-04-03 12:23:57 +0200 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2019-04-23 10:38:55 +0530 |
| commit | e2c114c06da2d9ffad5b16690abf008d6696f689 (patch) | |
| tree | 620e19030ebdf8405d027183d64e85845257b1a1 /drivers/dma | |
| parent | 23b846396b9501f9500cd8fb033a866f8c01f1a6 (diff) | |
| download | linux-e2c114c06da2d9ffad5b16690abf008d6696f689.tar.bz2 | |
dmaengine: at_xdmac: remove BUG_ON macro in tasklet
Even if this case shouldn't happen when controller is properly programmed,
it's still better to avoid dumping a kernel Oops for this.
As the sequence may happen only for debugging purposes, log the error and
just finish the tasklet call.
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/at_xdmac.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index fe69dccfa0c0..37a269420435 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c @@ -1606,7 +1606,11 @@ static void at_xdmac_tasklet(unsigned long data) struct at_xdmac_desc, xfer_node); dev_vdbg(chan2dev(&atchan->chan), "%s: desc 0x%p\n", __func__, desc); - BUG_ON(!desc->active_xfer); + if (!desc->active_xfer) { + dev_err(chan2dev(&atchan->chan), "Xfer not active: exiting"); + spin_unlock_bh(&atchan->lock); + return; + } txd = &desc->tx_dma_desc; |