summaryrefslogtreecommitdiffstats
path: root/drivers/char
diff options
context:
space:
mode:
authorNaveen Kumar Parna <parna.naveenkumar@gmail.com>2019-05-15 21:47:46 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-05-24 20:19:17 +0200
commit7256d7f401bdc9d3bd37c5de5f9b5f4f7e2de511 (patch)
tree7ea4dd4dab8f8f6803dd49428850cd22ac21f896 /drivers/char
parentb0576f9ecb5c51e9932531d23c447b2739261841 (diff)
downloadlinux-7256d7f401bdc9d3bd37c5de5f9b5f4f7e2de511.tar.bz2
bsr: do not use assignment in if condition
checkpatch.pl does not like assignment in if condition Signed-off-by: Naveen Kumar Parna <parna.naveenkumar@gmail.com> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/char')
-rw-r--r--drivers/char/bsr.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
index a6cef548e01e..70de334554a8 100644
--- a/drivers/char/bsr.c
+++ b/drivers/char/bsr.c
@@ -322,7 +322,8 @@ static int __init bsr_init(void)
goto out_err_2;
}
- if ((ret = bsr_create_devs(np)) < 0) {
+ ret = bsr_create_devs(np);
+ if (ret < 0) {
np = NULL;
goto out_err_3;
}