diff options
author | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2018-05-17 22:48:17 +0200 |
---|---|---|
committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2018-05-17 22:54:22 +0200 |
commit | 63d22063073b0ab46d1e06fe633fb5de8f5c58e1 (patch) | |
tree | a5bafd332a3436b98e5ae892d1708f73065f836b /drivers/block | |
parent | 30d7891ae903d1e2903033a3df453d7533011076 (diff) | |
download | linux-63d22063073b0ab46d1e06fe633fb5de8f5c58e1.tar.bz2 |
rtc: tps6586x: fix possible race condition
The probe function is not allowed to fail after the RTC is registered
because the following may happen:
CPU0: CPU1:
sys_load_module()
do_init_module()
do_one_initcall()
cmos_do_probe()
rtc_device_register()
__register_chrdev()
cdev->owner = struct module*
open("/dev/rtc0")
rtc_device_unregister()
module_put()
free_module()
module_free(mod->module_core)
/* struct module *module is now
freed */
chrdev_open()
spin_lock(cdev_lock)
cdev_get()
try_module_get()
module_is_live()
/* dereferences already
freed struct module* */
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Diffstat (limited to 'drivers/block')
0 files changed, 0 insertions, 0 deletions