diff options
| author | Lars-Peter Clausen <lars@metafoo.de> | 2015-03-07 17:10:01 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2015-03-07 16:17:33 +0000 |
| commit | 328f494d95aac8bd4896aea2328bc281053bcb71 (patch) | |
| tree | 611a00959c2ef443c65d0ec5727368ebc9749f13 /drivers/base | |
| parent | c517d838eb7d07bbe9507871fab3931deccff539 (diff) | |
| download | linux-328f494d95aac8bd4896aea2328bc281053bcb71.tar.bz2 | |
regmap: regcache-rbtree: Fix present bitmap resize
When inserting a new register into a block at the lower end the present
bitmap is currently shifted into the wrong direction. The effect of this is
that the bitmap becomes corrupted and registers which are present might be
reported as not present and vice versa.
Fix this by shifting left rather than right.
Fixes: 472fdec7380c("regmap: rbtree: Reduce number of nodes, take 2")
Reported-by: Daniel Baluta <daniel.baluta@gmail.com>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
Diffstat (limited to 'drivers/base')
| -rw-r--r-- | drivers/base/regmap/regcache-rbtree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/base/regmap/regcache-rbtree.c b/drivers/base/regmap/regcache-rbtree.c index d453a2c98ad0..81751a49d8bf 100644 --- a/drivers/base/regmap/regcache-rbtree.c +++ b/drivers/base/regmap/regcache-rbtree.c @@ -307,7 +307,7 @@ static int regcache_rbtree_insert_to_block(struct regmap *map, if (pos == 0) { memmove(blk + offset * map->cache_word_size, blk, rbnode->blklen * map->cache_word_size); - bitmap_shift_right(present, present, offset, blklen); + bitmap_shift_left(present, present, offset, blklen); } /* update the rbnode block, its size and the base register */ |