diff options
| author | Christoph Hellwig <hch@lst.de> | 2017-08-29 14:42:06 +0200 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2017-08-29 08:33:24 -0700 |
| commit | e8f11db956aa09c1618051a7aaf367d6810d8d8c (patch) | |
| tree | b4d766f6031e5a231cee41d0f33225ce45a7a009 /drivers/ata | |
| parent | 35f0b6a779b8b7a98faefd7c1c660b4dac9a5c26 (diff) | |
| download | linux-e8f11db956aa09c1618051a7aaf367d6810d8d8c.tar.bz2 | |
libata: check for trusted computing in IDENTIFY DEVICE data
ATA-8 and later mirrors the TRUSTED COMPUTING SUPPORTED bit in word 48 of
the IDENTIFY DEVICE data. Check this before issuing a READ LOG PAGE
command to avoid issues with buggy devices. The only downside is that
we can't support Security Send / Receive for a device with an older
revision due to the conflicting use of this field in earlier
specifications.
tj: The reason we need this is because some devices which don't
support READ LOG PAGE lock up after getting issued that command.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'drivers/ata')
| -rw-r--r-- | drivers/ata/libata-core.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 697f5f896b19..ca57b03ab950 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -2413,6 +2413,9 @@ static void ata_dev_config_trusted(struct ata_device *dev) u64 trusted_cap; unsigned int err; + if (!ata_id_has_trusted(dev->id)) + return; + if (!ata_identify_page_supported(dev, ATA_LOG_SECURITY)) { ata_dev_warn(dev, "Security Log not supported\n"); |