summaryrefslogtreecommitdiffstats
path: root/crypto
diff options
context:
space:
mode:
authorXin Long <lucien.xin@gmail.com>2019-11-18 17:39:34 +0800
committerDavid S. Miller <davem@davemloft.net>2019-11-18 17:17:07 -0800
commit4f0e97d070984d487df027f163e52bb72d1713d8 (patch)
tree55478381e28ee3f86e099e4af0edaa64753a5b84 /crypto
parent1fc1657775dc1b19e9ac1d46b4054ed8ae5d99ab (diff)
downloadlinux-4f0e97d070984d487df027f163e52bb72d1713d8.tar.bz2
net: sched: ensure opts_len <= IP_TUNNEL_OPTS_MAX in act_tunnel_key
info->options_len is 'u8' type, and when opts_len with a value > IP_TUNNEL_OPTS_MAX, 'info->options_len = opts_len' will cast int to u8 and set a wrong value to info->options_len. Kernel crashed in my test when doing: # opts="0102:80:00800022" # for i in {1..99}; do opts="$opts,0102:80:00800022"; done # ip link add name geneve0 type geneve dstport 0 external # tc qdisc add dev eth0 ingress # tc filter add dev eth0 protocol ip parent ffff: \ flower indev eth0 ip_proto udp action tunnel_key \ set src_ip 10.0.99.192 dst_ip 10.0.99.193 \ dst_port 6081 id 11 geneve_opts $opts \ action mirred egress redirect dev geneve0 So we should do the similar check as cls_flower does, return error when opts_len > IP_TUNNEL_OPTS_MAX in tunnel_key_copy_opts(). Fixes: 0ed5269f9e41 ("net/sched: add tunnel option support to act_tunnel_key") Signed-off-by: Xin Long <lucien.xin@gmail.com> Reviewed-by: Simon Horman <simon.horman@netronome.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'crypto')
0 files changed, 0 insertions, 0 deletions