diff options
author | yangerkun <yangerkun@huawei.com> | 2019-10-15 21:59:29 +0800 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2019-10-15 08:55:50 -0600 |
commit | 5da0fb1ab34ccfe6d49210b4f5a739c59fcbf25e (patch) | |
tree | c9eaf517afbc8c7dc8e2f9633ec17d6f0416e647 /block | |
parent | 7a7c5e715e722c86d602c56a09e77f000364e263 (diff) | |
download | linux-5da0fb1ab34ccfe6d49210b4f5a739c59fcbf25e.tar.bz2 |
io_uring: consider the overflow of sequence for timeout req
Now we recalculate the sequence of timeout with 'req->sequence =
ctx->cached_sq_head + count - 1', judge the right place to insert
for timeout_list by compare the number of request we still expected for
completion. But we have not consider about the situation of overflow:
1. ctx->cached_sq_head + count - 1 may overflow. And a bigger count for
the new timeout req can have a small req->sequence.
2. cached_sq_head of now may overflow compare with before req. And it
will lead the timeout req with small req->sequence.
This overflow will lead to the misorder of timeout_list, which can lead
to the wrong order of the completion of timeout_list. Fix it by reuse
req->submit.sequence to store the count, and change the logic of
inserting sort in io_timeout.
Signed-off-by: yangerkun <yangerkun@huawei.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions