diff options
author | Julia Lawall <julia@diku.dk> | 2011-06-06 18:59:02 -0700 |
---|---|---|
committer | Dave Jones <davej@redhat.com> | 2011-07-13 18:29:54 -0400 |
commit | 4911ca1031c2ade225fdf22cc872bc121c2c2ec5 (patch) | |
tree | f3e949229f7b1c112cd1c70cd3ebeb18df138ef4 /block | |
parent | 15964d388528c1dbb672027c8003fe7e81630a35 (diff) | |
download | linux-4911ca1031c2ade225fdf22cc872bc121c2c2ec5.tar.bz2 |
[CPUFREQ] s5pv210-cpufreq.c: Add missing clk_put
The successive calls to clk_get each call clk_put in the case of failure,
but this is not done for subsequent error handling code. The calls to
clk_get are moved to the end of the function, and appropriate gotos are
added.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
expression e1,e2;
statement S;
@@
e1 = clk_get@p1(...);
... when != e1 = e2
when != clk_put(e1)
when any
if (...) { ... when != clk_put(e1)
when != if (...) { ... clk_put(e1) ... }
* return@p3 ...;
} else S
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
Signed-off-by: Dave Jones <davej@redhat.com>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions