diff options
author | Damien Le Moal <damien.lemoal@wdc.com> | 2017-07-06 20:21:15 +0900 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2017-07-06 09:43:20 -0600 |
commit | 615d22a51c04856efe62af6e1d5b450aaf5cc2c0 (patch) | |
tree | 2d80a79b5a229c70969784fe3b1408e32b32679c /block/partitions | |
parent | 8a05aa4ce3bf767b7bd72851da89c23d084d1ecb (diff) | |
download | linux-615d22a51c04856efe62af6e1d5b450aaf5cc2c0.tar.bz2 |
block: Fix __blkdev_issue_zeroout loop
The BIO issuing loop in __blkdev_issue_zeroout() is allocating BIOs
with a maximum number of bvec (pages) equal to
min(nr_sects, (sector_t)BIO_MAX_PAGES)
This works since the requested number of bvecs will always be limited
to the absolute maximum number supported (BIO_MAX_PAGES), but this is
ineficient as too many bvec entries may be requested due to the
different units being used in the min() operation (number of sectors vs
number of pages).
To fix this, introduce the helper __blkdev_sectors_to_bio_pages() to
correctly calculate the number of bvecs for zeroout BIOs as the issuing
loop progresses. The calculation is done using consistent units and
makes sure that the number of pages return is at least 1 (for cases
where the number of sectors is less that the number of sectors in
a page).
Also remove a trailing space after the bit shift in the internal loop
min() call.
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/partitions')
0 files changed, 0 insertions, 0 deletions