diff options
author | Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com> | 2018-10-08 20:58:23 -0300 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2019-01-22 08:26:44 -0700 |
commit | 8b9433eb4de3c26a9226c981c283f9f4896ae030 (patch) | |
tree | d38a0f272d3ca37799f97cd4b63eb4a088747808 /block/blk-core.c | |
parent | 38197ca176fc259fa4c871d07bcf8389d044a895 (diff) | |
download | linux-8b9433eb4de3c26a9226c981c283f9f4896ae030.tar.bz2 |
direct-io: allow direct writes to empty inodes
On a DIO_SKIP_HOLES filesystem, the ->get_block() method is currently
not allowed to create blocks for an empty inode. This confusion comes
from trying to bit shift a negative number, so check the size of the
inode first.
The problem is most visible for hfsplus, because the fallback to
buffered I/O doesn't happen and the write fails with EIO. This is in
part the fault of the module, because it gives a wrong return value on
->get_block(); that will be fixed in a separate patch.
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-core.c')
0 files changed, 0 insertions, 0 deletions