diff options
| author | Dennis Zhou <dennis@kernel.org> | 2018-12-19 16:43:53 -0600 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2018-12-21 08:47:58 -0700 |
| commit | 6b4505352e4b1ee27faa97ae46b9baa8bc6a31f0 (patch) | |
| tree | 80cafb7e41f07569eeacf1afd3816ffb97a80be8 /block/blk-cgroup.c | |
| parent | 6ab2187992f4b0112852e5a097a2b6c7d167e2e5 (diff) | |
| download | linux-6b4505352e4b1ee27faa97ae46b9baa8bc6a31f0.tar.bz2 | |
blkcg: remove unused __blkg_release_rcu()
An earlier commit 7fcf2b033b84 ("blkcg: change blkg reference counting
to use percpu_ref") moved around the release call from blkg_put() to be
a part of the percpu_ref cleanup. Remove the additional unused code
which should have been removed earlier.
Signed-off-by: Dennis Zhou <dennis@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-cgroup.c')
| -rw-r--r-- | block/blk-cgroup.c | 23 |
1 files changed, 0 insertions, 23 deletions
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index c8cc1cbb6370..2bed5725aa03 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -438,29 +438,6 @@ static void blkg_destroy_all(struct request_queue *q) spin_unlock_irq(&q->queue_lock); } -/* - * A group is RCU protected, but having an rcu lock does not mean that one - * can access all the fields of blkg and assume these are valid. For - * example, don't try to follow throtl_data and request queue links. - * - * Having a reference to blkg under an rcu allows accesses to only values - * local to groups like group stats and group rate limits. - */ -void __blkg_release_rcu(struct rcu_head *rcu_head) -{ - struct blkcg_gq *blkg = container_of(rcu_head, struct blkcg_gq, rcu_head); - - /* release the blkcg and parent blkg refs this blkg has been holding */ - css_put(&blkg->blkcg->css); - if (blkg->parent) - blkg_put(blkg->parent); - - wb_congested_put(blkg->wb_congested); - - blkg_free(blkg); -} -EXPORT_SYMBOL_GPL(__blkg_release_rcu); - static int blkcg_reset_stats(struct cgroup_subsys_state *css, struct cftype *cftype, u64 val) { |