diff options
| author | Len Brown <len.brown@intel.com> | 2010-02-19 00:09:22 -0500 | 
|---|---|---|
| committer | Len Brown <len.brown@intel.com> | 2010-03-14 20:58:38 -0400 | 
| commit | 68ca406930d6380b3be7ada5f15fcf85bfcbd552 (patch) | |
| tree | 866864defb2733d71bce04e342638c60f92fb928 /arch | |
| parent | 4c81ba4900ab4eb24c7d2ba1aca594c644b6ce4c (diff) | |
| download | linux-68ca406930d6380b3be7ada5f15fcf85bfcbd552.tar.bz2 | |
ACPI: delete the "acpi=ht" boot option
acpi=ht was important in 2003 -- before ACPI was
universally deployed and enabled by default in
the major Linux distributions.
At that time, there were a fair number of people who
or chose to, or needed to, run with acpi=off,
yet also wanted access to Hyper-threading.
Today we find that many invocations of "acpi=ht"
are accidental, and thus is it possible that it
is doing more harm than good.
In 2.6.34, we warn on invocation of acpi=ht.
In 2.6.35, we delete the boot option.
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/ia64/include/asm/acpi.h | 1 | ||||
| -rw-r--r-- | arch/x86/include/asm/acpi.h | 2 | ||||
| -rw-r--r-- | arch/x86/kernel/acpi/boot.c | 19 | ||||
| -rw-r--r-- | arch/x86/lguest/boot.c | 1 | 
4 files changed, 3 insertions, 20 deletions
| diff --git a/arch/ia64/include/asm/acpi.h b/arch/ia64/include/asm/acpi.h index 21adbd7f90f8..837dc82a013e 100644 --- a/arch/ia64/include/asm/acpi.h +++ b/arch/ia64/include/asm/acpi.h @@ -94,7 +94,6 @@ ia64_acpi_release_global_lock (unsigned int *lock)  #define acpi_noirq 0	/* ACPI always enabled on IA64 */  #define acpi_pci_disabled 0 /* ACPI PCI always enabled on IA64 */  #define acpi_strict 1	/* no ACPI spec workarounds on IA64 */ -#define acpi_ht 0	/* no HT-only mode on IA64 */  #endif  #define acpi_processor_cstate_check(x) (x) /* no idle limits on IA64 :) */  static inline void disable_acpi(void) { } diff --git a/arch/x86/include/asm/acpi.h b/arch/x86/include/asm/acpi.h index 56f462cf22d2..aa2c39d968fc 100644 --- a/arch/x86/include/asm/acpi.h +++ b/arch/x86/include/asm/acpi.h @@ -85,7 +85,6 @@ extern int acpi_ioapic;  extern int acpi_noirq;  extern int acpi_strict;  extern int acpi_disabled; -extern int acpi_ht;  extern int acpi_pci_disabled;  extern int acpi_skip_timer_override;  extern int acpi_use_timer_override; @@ -97,7 +96,6 @@ void acpi_pic_sci_set_trigger(unsigned int, u16);  static inline void disable_acpi(void)  {  	acpi_disabled = 1; -	acpi_ht = 0;  	acpi_pci_disabled = 1;  	acpi_noirq = 1;  } diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c index 7914ab0ad76e..63bcf39f8f24 100644 --- a/arch/x86/kernel/acpi/boot.c +++ b/arch/x86/kernel/acpi/boot.c @@ -62,7 +62,6 @@ EXPORT_SYMBOL(acpi_disabled);  int acpi_noirq;				/* skip ACPI IRQ initialization */  int acpi_pci_disabled;		/* skip ACPI PCI scan and IRQ initialization */  EXPORT_SYMBOL(acpi_pci_disabled); -int acpi_ht __initdata = 1;	/* enable HT */  int acpi_lapic;  int acpi_ioapic; @@ -1460,9 +1459,8 @@ void __init acpi_boot_table_init(void)  	/*  	 * If acpi_disabled, bail out -	 * One exception: acpi=ht continues far enough to enumerate LAPICs  	 */ -	if (acpi_disabled && !acpi_ht) +	if (acpi_disabled)  		return;   	/* @@ -1493,9 +1491,8 @@ int __init early_acpi_boot_init(void)  {  	/*  	 * If acpi_disabled, bail out -	 * One exception: acpi=ht continues far enough to enumerate LAPICs  	 */ -	if (acpi_disabled && !acpi_ht) +	if (acpi_disabled)  		return 1;  	/* @@ -1513,9 +1510,8 @@ int __init acpi_boot_init(void)  	/*  	 * If acpi_disabled, bail out -	 * One exception: acpi=ht continues far enough to enumerate LAPICs  	 */ -	if (acpi_disabled && !acpi_ht) +	if (acpi_disabled)  		return 1;  	acpi_table_parse(ACPI_SIG_BOOT, acpi_parse_sbf); @@ -1550,21 +1546,12 @@ static int __init parse_acpi(char *arg)  	/* acpi=force to over-ride black-list */  	else if (strcmp(arg, "force") == 0) {  		acpi_force = 1; -		acpi_ht = 1;  		acpi_disabled = 0;  	}  	/* acpi=strict disables out-of-spec workarounds */  	else if (strcmp(arg, "strict") == 0) {  		acpi_strict = 1;  	} -	/* Limit ACPI just to boot-time to enable HT */ -	else if (strcmp(arg, "ht") == 0) { -		if (!acpi_force) { -			printk(KERN_WARNING "acpi=ht will be removed in Linux-2.6.35\n"); -			disable_acpi(); -		} -		acpi_ht = 1; -	}  	/* acpi=rsdt use RSDT instead of XSDT */  	else if (strcmp(arg, "rsdt") == 0) {  		acpi_rsdt_forced = 1; diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c index 7e59dc1d3fc2..8eb9eed60282 100644 --- a/arch/x86/lguest/boot.c +++ b/arch/x86/lguest/boot.c @@ -1391,7 +1391,6 @@ __init void lguest_init(void)  #endif  #ifdef CONFIG_ACPI  	acpi_disabled = 1; -	acpi_ht = 0;  #endif  	/* |