diff options
| author | David S. Miller <davem@davemloft.net> | 2015-11-04 11:30:57 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-11-04 11:30:57 -0800 |
| commit | d618382ba5f1a4905db63f4980bf7b0a5826de9d (patch) | |
| tree | 5bc612d222a70276b0e4d9df476b2548c1286d9e /arch/sparc/kernel/ldc.c | |
| parent | 73958c651fbf70d8d8bf2a60b871af5f7a2e3199 (diff) | |
| download | linux-d618382ba5f1a4905db63f4980bf7b0a5826de9d.tar.bz2 | |
iommu-common: Fix error code used in iommu_tbl_range_{alloc,free}().
The value returned from iommu_tbl_range_alloc() (and the one passed
in as a fourth argument to iommu_tbl_range_free) is not a DMA address,
it is rather an index into the IOMMU page table.
Therefore using DMA_ERROR_CODE is not appropriate.
Use a more type matching error code define, IOMMU_ERROR_CODE, and
update all users of this interface.
Reported-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/sparc/kernel/ldc.c')
| -rw-r--r-- | arch/sparc/kernel/ldc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/sparc/kernel/ldc.c b/arch/sparc/kernel/ldc.c index 1ae5eb1bb045..59d503866431 100644 --- a/arch/sparc/kernel/ldc.c +++ b/arch/sparc/kernel/ldc.c @@ -1953,7 +1953,7 @@ static struct ldc_mtable_entry *alloc_npages(struct ldc_iommu *iommu, entry = iommu_tbl_range_alloc(NULL, &iommu->iommu_map_table, npages, NULL, (unsigned long)-1, 0); - if (unlikely(entry < 0)) + if (unlikely(entry == IOMMU_ERROR_CODE)) return NULL; return iommu->page_table + entry; |