summaryrefslogtreecommitdiffstats
path: root/arch/s390
diff options
context:
space:
mode:
authorJulien Brunel <brunel@diku.dk>2008-08-21 19:46:30 +0200
committerMartin Schwidefsky <schwidefsky@de.ibm.com>2008-08-21 19:46:39 +0200
commit0983e56835cbf4796e8f5780c549c32ac1c3afac (patch)
treed0a98012929abcd12d95c7a96184a69b1b1d4c6b /arch/s390
parent6a55617ed5d1aa62b850de2cf66f5ede2eef4825 (diff)
downloadlinux-0983e56835cbf4796e8f5780c549c32ac1c3afac.tar.bz2
[S390] drivers/s390: Use an IS_ERR test rather than a NULL test
In case of error, functions dasd_kmalloc_request and idal_buffer_alloc return an ERR pointer, but never return the NULL pointer. So after a call to one of these functions, a NULL test should be replaced by an IS_ERR test. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @correct_null_test@ expression x,E; statement S1, S2; @@ x = ( dasd_kmalloc_request(...) | idal_buffer_alloc(...) ) <... when != x = E if ( ( - x@p2 != NULL + ! IS_ERR ( x ) | - x@p2 == NULL + IS_ERR( x ) ) ) S1 else S2 ...> ? x = E; // </smpl> Signed-off-by: Julien Brunel <brunel@diku.dk> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'arch/s390')
0 files changed, 0 insertions, 0 deletions