diff options
author | Laurent Dufour <ldufour@linux.ibm.com> | 2020-07-27 12:24:29 -0700 |
---|---|---|
committer | Paul Mackerras <paulus@ozlabs.org> | 2020-07-28 12:34:52 +1000 |
commit | 81ab595ddd3c3036806b460526e1fbc5b271ff33 (patch) | |
tree | a5966edd5a6075576692bad2f5f560fdd4a07bde /arch/powerpc/kvm/book3s_pr.c | |
parent | f1b87ea8784b8c79d9bffad60fe0720c2cb21ec7 (diff) | |
download | linux-81ab595ddd3c3036806b460526e1fbc5b271ff33.tar.bz2 |
KVM: PPC: Book3S HV: Rework secure mem slot dropping
When a secure memslot is dropped, all the pages backed in the secure
device (aka really backed by secure memory by the Ultravisor)
should be paged out to a normal page. Previously, this was
achieved by triggering the page fault mechanism which is calling
kvmppc_svm_page_out() on each pages.
This can't work when hot unplugging a memory slot because the memory
slot is flagged as invalid and gfn_to_pfn() is then not trying to access
the page, so the page fault mechanism is not triggered.
Since the final goal is to make a call to kvmppc_svm_page_out() it seems
simpler to call directly instead of triggering such a mechanism. This
way kvmppc_uvmem_drop_pages() can be called even when hot unplugging a
memslot.
Since kvmppc_uvmem_drop_pages() is already holding kvm->arch.uvmem_lock,
the call to __kvmppc_svm_page_out() is made. As
__kvmppc_svm_page_out needs the vma pointer to migrate the pages,
the VMA is fetched in a lazy way, to not trigger find_vma() all
the time. In addition, the mmap_sem is held in read mode during
that time, not in write mode since the virual memory layout is not
impacted, and kvm->arch.uvmem_lock prevents concurrent operation
on the secure device.
Reviewed-by: Bharata B Rao <bharata@linux.ibm.com>
Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
[modified check on the VMA in kvmppc_uvmem_drop_pages]
Signed-off-by: Ram Pai <linuxram@us.ibm.com>
[modified the changelog description]
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
Diffstat (limited to 'arch/powerpc/kvm/book3s_pr.c')
0 files changed, 0 insertions, 0 deletions