diff options
| author | Frederic Barrat <fbarrat@linux.ibm.com> | 2018-07-31 15:24:52 +0200 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2018-08-01 23:23:41 +1000 |
| commit | cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a (patch) | |
| tree | 1c64ea127a8a4df5c6d9513a33ac200e111097bb /arch/powerpc/kernel/idle_book3s.S | |
| parent | b03897cf318dfc47de33a7ecbc7655584266f034 (diff) | |
| download | linux-cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a.tar.bz2 | |
powerpc/64s/radix: Fix missing global invalidations when removing copro
With the optimizations for TLB invalidation from commit 0cef77c7798a
("powerpc/64s/radix: flush remote CPUs out of single-threaded
mm_cpumask"), the scope of a TLBI (global vs. local) can now be
influenced by the value of the 'copros' counter of the memory context.
When calling mm_context_remove_copro(), the 'copros' counter is
decremented first before flushing. It may have the unintended side
effect of sending local TLBIs when we explicitly need global
invalidations in this case. Thus breaking any nMMU user in a bad and
unpredictable way.
Fix it by flushing first, before updating the 'copros' counter, so
that invalidations will be global.
Fixes: 0cef77c7798a ("powerpc/64s/radix: flush remote CPUs out of single-threaded mm_cpumask")
Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
Tested-by: Vaibhav Jain <vaibhav@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'arch/powerpc/kernel/idle_book3s.S')
0 files changed, 0 insertions, 0 deletions