diff options
author | Hans de Goede <hdegoede@redhat.com> | 2014-03-15 16:04:54 +0100 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2014-03-19 12:34:29 +0100 |
commit | cc3b68fea29c3af018734501e166124c8eb04a6c (patch) | |
tree | cfb82a97dbffdb188193e007c2f8231c1d2b6444 /arch/m68k/atari/ataints.c | |
parent | 915b78ce8ef0178305cb100e830832a866b42faa (diff) | |
download | linux-cc3b68fea29c3af018734501e166124c8eb04a6c.tar.bz2 |
irqchip: sun4i: Simplify sun4i_irq_ack
Now that we only ack irq 0 the code can be simplified a lot.
Also switch from read / modify / write to a simple write clear:
1) This is what the android code does (it has a hack for acking irq 0
in its unmask code doing this)
2) read / modify / write simply does not make sense for an irq status
register like this, if the other bits are writeable (and the data sheet says
they are not) they should be write 1 to clear, since otherwise a read /
modify / write can race with a device raising an interrupt and then clear
the pending bit unintentionally
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-sunxi@googlegroups.com
Link: http://lkml.kernel.org/r/1394895894-8891-3-git-send-email-hdegoede@redhat.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'arch/m68k/atari/ataints.c')
0 files changed, 0 insertions, 0 deletions