diff options
| author | Ben Dooks <ben-linux@fluff.org> | 2010-01-18 15:37:25 +0900 |
|---|---|---|
| committer | Ben Dooks <ben-linux@fluff.org> | 2010-01-18 15:37:25 +0900 |
| commit | f3b464cca94c4a8f54fbc11ec5af8b143fd1750b (patch) | |
| tree | 8bc976f445c0bfdc85336eadb84e1c06279e3736 /arch/arm/plat-samsung/clock-clksrc.c | |
| parent | b8792dbff6ed93c5a77f71917d4a0c5efa12eee1 (diff) | |
| download | linux-f3b464cca94c4a8f54fbc11ec5af8b143fd1750b.tar.bz2 | |
ARM: SAMSUNG: Fix clksrc-clk's checks for bad register settings
The WARN_ON() was only checking the first clock in the array, instead of
being executed for each clksrc clock being registered.
Since this is an array of clocks, WARN_ON() does not provide a lot of
useful information about the problem, so change to using printk(KERN_ERR)
to report the problem to the console.
As a note, we still try and register the clock even if these problems are
present just in case and to avoid changing the behaviour of the registration
process.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Diffstat (limited to 'arch/arm/plat-samsung/clock-clksrc.c')
| -rw-r--r-- | arch/arm/plat-samsung/clock-clksrc.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/arch/arm/plat-samsung/clock-clksrc.c b/arch/arm/plat-samsung/clock-clksrc.c index 98c6b8859f49..656c70e0400a 100644 --- a/arch/arm/plat-samsung/clock-clksrc.c +++ b/arch/arm/plat-samsung/clock-clksrc.c @@ -177,9 +177,11 @@ void __init s3c_register_clksrc(struct clksrc_clk *clksrc, int size) { int ret; - WARN_ON(!clksrc->reg_div.reg && !clksrc->reg_src.reg); - for (; size > 0; size--, clksrc++) { + if (!clksrc->reg_div.reg && !clksrc->reg_src.reg) + printk(KERN_ERR "%s: clock %s has no registers set\n", + __func__, clksrc->clk.name); + /* fill in the default functions */ if (!clksrc->clk.ops) { |