diff options
| author | David Vrabel <david.vrabel@citrix.com> | 2013-02-14 03:18:57 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-02-14 13:16:49 -0500 |
| commit | 35876b5ffc154c357476b2c3bdab10feaf4bd8f0 (patch) | |
| tree | 212f9ce2fa64a9dc2e25bdf29806dfc39e357cc9 /arch/arm/net | |
| parent | 306dbf9e5509da5aa8a787f13231442bc3ba697a (diff) | |
| download | linux-35876b5ffc154c357476b2c3bdab10feaf4bd8f0.tar.bz2 | |
xen-netback: correctly return errors from netbk_count_requests()
netbk_count_requests() could detect an error, call
netbk_fatal_tx_error() but return 0. The vif may then be used
afterwards (e.g., in a call to netbk_tx_error().
Since netbk_fatal_tx_error() could set vif->refcnt to 1, the vif may
be freed immediately after the call to netbk_fatal_tx_error() (e.g.,
if the vif is also removed).
Netback thread Xenwatch thread
-------------------------------------------
netbk_fatal_tx_err() netback_remove()
xenvif_disconnect()
...
free_netdev()
netbk_tx_err() Oops!
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: Jan Beulich <JBeulich@suse.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Reported-by: Christopher S. Aker <caker@theshore.net>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/arm/net')
0 files changed, 0 insertions, 0 deletions