diff options
author | Russell King <rmk+kernel@arm.linux.org.uk> | 2015-08-26 20:07:25 +0100 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2015-08-26 20:25:48 +0100 |
commit | aa06e5c1f9c2b466712be904cc5b56a813e24cfd (patch) | |
tree | 2fc918f13ee339a2dacba778f7ab82d945fdfc1e /arch/arm/mm/abort-macro.S | |
parent | 3fba7e23f754a9a6e639b640fa2a393712ffe1b8 (diff) | |
download | linux-aa06e5c1f9c2b466712be904cc5b56a813e24cfd.tar.bz2 |
ARM: entry: get rid of multiple macro definitions
The following structure is just asking for trouble:
#ifdef CONFIG_symbol
.macro foo
...
.endm
.macro bar
...
.endm
.macro baz
...
.endm
#else
.macro foo
...
.endm
.macro bar
...
.endm
#ifdef CONFIG_symbol2
.macro baz
...
.endm
#else
.macro baz
...
.endm
#endif
#endif
such as one defintion being updated, but the other definitions miss out.
Where the contents of a macro needs to be conditional, the hint is in
the first clause of this very sentence. "contents" "conditional". Not
multiple separate definitions, especially not when much of the macro
is the same between different configs.
This patch fixes this bad style, which had caused the Thumb2 code to
miss-out on the uaccess updates.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/mm/abort-macro.S')
0 files changed, 0 insertions, 0 deletions