diff options
| author | Hui Peng <benquike@gmail.com> | 2019-08-19 18:02:29 -0400 |
|---|---|---|
| committer | Kalle Valo <kvalo@codeaurora.org> | 2019-09-03 16:54:48 +0300 |
| commit | 8b51dc7291473093c821195c4b6af85fadedbc2f (patch) | |
| tree | 0916f8bcb99e67232241dd779e793b8a8e340c58 /README | |
| parent | 13fa451568ab9e8b3074ef741477c7938c713c42 (diff) | |
| download | linux-8b51dc7291473093c821195c4b6af85fadedbc2f.tar.bz2 | |
rsi: fix a double free bug in rsi_91x_deinit()
`dev` (struct rsi_91x_usbdev *) field of adapter
(struct rsi_91x_usbdev *) is allocated and initialized in
`rsi_init_usb_interface`. If any error is detected in information
read from the device side, `rsi_init_usb_interface` will be
freed. However, in the higher level error handling code in
`rsi_probe`, if error is detected, `rsi_91x_deinit` is called
again, in which `dev` will be freed again, resulting double free.
This patch fixes the double free by removing the free operation on
`dev` in `rsi_init_usb_interface`, because `rsi_91x_deinit` is also
used in `rsi_disconnect`, in that code path, the `dev` field is not
(and thus needs to be) freed.
This bug was found in v4.19, but is also present in the latest version
of kernel. Fixes CVE-2019-15504.
Reported-by: Hui Peng <benquike@gmail.com>
Reported-by: Mathias Payer <mathias.payer@nebelwelt.net>
Signed-off-by: Hui Peng <benquike@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'README')
0 files changed, 0 insertions, 0 deletions